Issue 43547 - ux-ctest: Hide slide stay hide slide also when the slide is hidden
Summary: ux-ctest: Hide slide stay hide slide also when the slide is hidden
Status: CLOSED FIXED
Alias: None
Product: Impress
Classification: Application
Component: ui (show other issues)
Version: 680m80
Hardware: All All
: P3 Trivial (vote)
Target Milestone: OOo 2.2
Assignee: christian.guenther
QA Contact: issues@graphics
URL: http://specs.openoffice.org/impress/m...
Keywords:
: 58696 61847 62185 68766 (view as issue list)
Depends on:
Blocks:
 
Reported: 2005-02-25 15:54 UTC by christian.guenther
Modified: 2008-06-21 07:43 UTC (History)
4 users (show)

See Also:
Issue Type: FEATURE
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
Test case specification (7.16 KB, text/html)
2006-12-08 14:41 UTC, christian.guenther
no flags Details

Note You need to log in before you can comment on or make changes to this issue.
Description christian.guenther 2005-02-25 15:54:45 UTC
- start an Impress
- hide the slide witht the context menu of the slide in the slide sorter bar
- open the context menu of the now hidden slide again
- you can still read hide Slide but the slide is already hidden.
- the entry should change to show slide or something else.
Comment 1 groucho266 2005-02-25 17:04:58 UTC
I think this should better be a checkable entry.  This way we do not have to
introduce a new string (and find a way to exchange it in the menu and update
mnemonics etc.).
Comment 2 groucho266 2005-02-25 17:16:50 UTC
The state (hidden or visible) is indicated correctly in the slide sorter: the
page number painted with a strike through (or is it crossed?) effect.  So this
issue is not so grave.
Comment 3 ooo 2005-02-25 20:09:25 UTC
set to OOo 2.0.1
Comment 4 groucho266 2005-05-24 13:57:11 UTC
Due to resource constraints I set the target to OOo Later.
Comment 5 matthias.mueller-prove 2006-08-14 14:31:09 UTC
cc myself,
change target to 2.x

The ui sends conflicting status information to the user. The menu item string
should be in synch with the visibility state of the slide. Please consider this
issue for an upcomming update.
Comment 6 matthias.mueller-prove 2006-08-14 16:44:09 UTC
spec update at http://specs.openoffice.org/impress/multipane/MultiPaneGUI.sxw
target change to 2.1
Comment 7 matthias.mueller-prove 2006-08-14 18:11:19 UTC
change type to FEATURE. It worked as spec'ed.
Comment 8 matthias.mueller-prove 2006-08-18 12:39:43 UTC
new spec URL
Comment 9 matthias.mueller-prove 2006-08-25 16:29:40 UTC
change summary -- this is also issue #38 found in the C0-Usability Test
Comment 10 matthias.mueller-prove 2006-09-14 11:16:51 UTC
Andre, we also need to take care for the Slide View toolbar. It contains a
Show/Hide Slide control. Now it needs to contain a Hide Slide control and a Show
Slide control to conform to the menu and the context menu.
Comment 11 matthias.mueller-prove 2006-09-14 11:27:38 UTC
see row 39 of spec http://specs.openoffice.org/impress/menus/SlideShowMenu.odt
Comment 12 matthias.mueller-prove 2006-09-14 11:45:27 UTC
I'll paste my toolbar comments to i68767, where they belong to.
Comment 13 matthias.mueller-prove 2006-10-09 10:44:10 UTC
Will be done for OOo 2.2
See release map at http://wiki.services.openoffice.org/wiki/OOoRelease22 for UI
Freeze.
Comment 14 matthias.mueller-prove 2006-10-09 12:56:12 UTC
set target OOo 2.2
Comment 15 christian.guenther 2006-12-01 10:51:17 UTC
*** Issue 68766 has been marked as a duplicate of this issue. ***
Comment 16 groucho266 2006-12-01 15:41:20 UTC
Made the necessary changes so that the main menu, the slide sorter popup menu,
and the slide sorter tool bar show two entries, one for including and one for
excluding the selected slides from the slide show.

Changed the code in the HideSlideFunction from toggling the exclusion state to
either setting or resetting it, depending on the slot id.

New files:
/default_images/res/commandimagelist/Attic/lch_showslide.png    rev. 1.1.2.1
/default_images/res/commandimagelist/Attic/lc_showslide.png    rev. 1.1.2.1
/default_images/res/commandimagelist/Attic/sch_showslide.png    rev. 1.1.2.1
/default_images/res/commandimagelist/Attic/sc_showslide.png    rev. 1.1.2.1

Modified files:
/default_images/res/commandimagelist/lc_hideslide.png    rev. 1.2.22.1
/default_images/res/commandimagelist/lch_hideslide.png    rev. 1.2.22.1
/default_images/res/commandimagelist/sch_hideslide.png    rev. 1.2.22.1
/default_images/res/commandimagelist/sc_hideslide.png    rev. 1.2.22.1
/officecfg/registry/data/org/openoffice/Office/UI/DrawImpressCommands.xcu   
rev. 1.19.16.1
/sd/inc/app.hrc    rev. 1.19.86.1
/sd/sdi/SlideSorterController.sdi    rev. 1.12.144.1
/sd/uiconfig/simpress/menubar/menubar.xml    rev. 1.29.76.1
/sd/uiconfig/simpress/toolbar/slideviewobjectbar.xml    rev. 1.4.492.1
/sd/source/ui/app/menuids3_tmpl.src    rev. 1.6.318.1
/sd/source/ui/app/menuids_tmpl.src    rev. 1.12.104.1
/sd/source/ui/app/popup.src    rev. 1.36.318.1
/sd/source/ui/slidesorter/controller/SlideSorterController.cxx    rev. 1.36.10.1
/sd/source/ui/slidesorter/controller/SlsSlotManager.cxx    rev. 1.25.10.1
/sd/source/ui/slidesorter/controller/SlsHideSlideFunction.cxx    rev. 1.6.48.1
/sd/source/ui/slidesorter/controller/SlsHideSlideFunction.cxx    rev. 1.4.258.1
Comment 17 groucho266 2006-12-05 17:16:14 UTC
Please verify.
Comment 18 groucho266 2006-12-06 16:04:55 UTC
Changed behaviour so that both the hide slide and the show slide menu entries
are enabled for mixed selections.

Modified file is
/sd/source/ui/slidesorter/controller/SlsSlotManager.cxx    rev. 1.25.10.2
Comment 19 groucho266 2006-12-06 16:16:31 UTC
Fixed some compiler problems

Modified file:
/sd/source/ui/slidesorter/controller/SlsSlotManager.cxx    rev. 1.25.10.3
Comment 20 christian.guenther 2006-12-08 14:41:21 UTC
Created attachment 41254 [details]
Test case specification
Comment 21 christian.guenther 2006-12-08 15:08:32 UTC
CGU: Verified in cws impress111
Comment 22 ace_dent 2006-12-20 15:12:40 UTC
Marking icon issue for my own notes. Cheers.
Comment 23 christian.guenther 2007-02-01 14:23:02 UTC
CGU: Integrated in OOF680m5 and SCR680m201
Comment 24 jr 2008-06-21 07:18:52 UTC
*** Issue 62185 has been marked as a duplicate of this issue. ***
Comment 25 jr 2008-06-21 07:23:52 UTC
*** Issue 62185 has been marked as a duplicate of this issue. ***
Comment 26 jr 2008-06-21 07:41:59 UTC
*** Issue 61847 has been marked as a duplicate of this issue. ***
Comment 27 jr 2008-06-21 07:43:33 UTC
*** Issue 58696 has been marked as a duplicate of this issue. ***